excel - vba find value then paste another into different cell in another column -

-

i'm running macro looks value column of 'sheet 1' in column c of sheet 2, if these match value column b of sheet 1 should copied column m of corresponding row in sheet 2.

the macro have works, because massive worksheet, loop in taking far time. because sheet 1 has around 300,000 rows , value in each instance unique. in sheet 2 there around 50,000 rows. it's been running overnight , has reached 60,000 rows in sheet 1 far

i'm no means vba expert, or intermediate i've read maybe using find faster looking match , looping?

this macro i'm using

 option explicit  sub lookupandcopy() application.screenupdating = true  dim j long, long, lastrow1 long, lastrow2 long dim sh_1, sh_3 worksheet dim myname string  set sh_1 = sheets("sheet1")  set sh_3 = sheets("sheet2")   lastrow1 = sh_1.usedrange.rows.count   j = 2 lastrow1 myname = sh_1.cells(j, 1).value    lastrow2 = sh_3.usedrange.rows.count  = 2 lastrow2     if sh_3.cells(i, 3).value = myname         sh_3.cells(i, 13).value = sh_1.cells(j, 2).value      end if      next    next j  application.screenupdating = true end sub

if i've missed off or other detail that's needed please let me know!

you seem using columns , b in sheet1 dictionary (and accessing values linear search). why not load values dictionary objects has o(1) search? make sure project includes reference microsoft scripting runtime (tools > references in vbe if haven't done such things) try:

sub lookupandcopy()     application.screenupdating = false      dim avals new dictionary     dim long, j long, lastrow1 long, lastrow2 long     dim sh_1, sh_3 worksheet     dim myname string      set sh_1 = sheets("sheet1")     set sh_3 = sheets("sheet2")      sh_1         lastrow1 = .range("a:a").rows.count 'last row in spreadsheet         lastrow1 = .cells(lastrow1, 1).end(xlup).row 'last used row in column         'load aval dict         j = 2 lastrow1             myname = .cells(j, 1).value             if len(myname) > 0 avals.add myname, .cells(j, 2).value         next j     end      sh_3         lastrow2 = .range("a:a").rows.count         lastrow2 = .cells(lastrow2, 3).end(xlup).row 'last used row in column 3         = 2 lastrow2             myname = .cells(i, 3).value             if avals.exists(myname)                 .cells(i, 13).value = avals.item(myname)             end if          next     end     application.screenupdating = true end sub

if have repeated values in column need store values collections of row indices value occurs, effort of setting such dictionary still better using nested loops.


Comments

Post a Comment

Popular posts from this blog

python - No exponential form of the z-axis in matplotlib-3D-plots -

-
Image
i have similar problem described in how prevent numbers being changed exponential form in python matplotlib figure : i don't want (in special case) weird scientific formatting of axis. problem different have problem @ z -axis. 2-d plots can use ax.get_yaxis().get_major_formatter().set_useoffset(false) . , there no function ax.get_zaxis() what use format z -axis same way? edit: example: from mpl_toolkits.mplot3d import axes3d import numpy np import sys import matplotlib import matplotlib.pyplot pyplot def func(xi, ti): res = 10e3 + np.cos(ti) * np.sin(xi) return res if __name__ == '__main__': timespacing = 20 timestart = 0 timeend = 1 time = np.linspace(timestart, timeend, timespacing) widthspacing = 50 widthstart = 0 widthend = 3 width = np.linspace(widthstart, widthend, widthspacing) reslist = [] matplotlib.rcparams['legend.fontsize'] = 10 fig = pyplot.figure() ax = fig.gca(projection = '3d...
Read more

php - Best Light server (Linux + Web server + Database) for Raspberry Pi -

-
i install web server database on raspberry pi (little computer). computer has 1gb ram. i want know best combination: linux distribution , web server , dbms run local server multiple users minimal latency, use php on server. , best settings performance , not have bugs (memory usage, disable plugin, disable service, etc)? i thought light debian , lighttpd server , sqlite database. solution? i think lighttpd + sqlite great choice. linux distro, debian @ centos or tiny core linux , although i'm not sure of compatibility pi. obviously, can't go wrong raspbian if want use in production , more stable performance, few more pi's , set them in cluster .
Read more

c# - "Newtonsoft.Json.JsonSerializationException unable to find constructor to use for types" error when deserializing class -

-
i developing app in xamarin android. have splash screen serialize class , pass mainactivity using intent . when try deserialize in mainactivity error message : "serializationexception unable find constructor use types" serialization : void loaddata() { currency currency = new currency(this); intent = new intent(this, typeof(mainactivity)); intent.putextra("currency", newtonsoft.json.jsonconvert.serializeobject(currency)); startactivity(intent); } deserialization : cur = newtonsoft.json.jsonconvert.deserializeobject<currency> (intent.getstringextra("currency")); // error here class constructor : public currency(context context) { thiscontext = context; } i began experiencing problem after added parameter context context constructor. has caused this? how can solve it? possible serialize/deserialize class has parameters? you need have empty constructor in currency class in order deserialize it. ...
Read more